Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/esp32s2-lilygo-ttgo-t8: fix STDIO selection in Kconfig #19287

Merged
merged 2 commits into from
Feb 18, 2023
Merged

boards/esp32s2-lilygo-ttgo-t8: fix STDIO selection in Kconfig #19287

merged 2 commits into from
Feb 18, 2023

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR fixes the default STDIO selection in Kconfig in case the USB port is connected to the USB to UART bridge which is then used for STDIO (default). It solves the compilation problems in the nightly build.

The PR also includes a very small documentation fix.

Testing procedure

Green CI.

The compilations that caused problems in nightly build should pass:

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/pkg_tinyusb_cdc_msc -b  esp32s2-lilygo-ttgo-t8 -j8

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/sys_fido2_ctap/ -b  esp32s2-lilygo-ttgo-t8 -j8

python3 dist/tools/compile_test/compile_like_murdock.py -a tests/usbus_board_reset/ -b  esp32s2-lilygo-ttgo-t8 -j8

Issues/PRs references

@github-actions github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration labels Feb 18, 2023
@gschorcht gschorcht added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Feb 18, 2023
@riot-ci
Copy link

riot-ci commented Feb 18, 2023

Murdock results

✔️ PASSED

5207c6f boards/esp32s2-lilygo-ttgo-t8: documentation fix

Success Failures Total Runtime
510 0 510 06m:49s

Artifacts

@gschorcht gschorcht requested a review from benpicco February 18, 2023 11:11
benpicco
benpicco approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 18, 2023

Build succeeded:

@bors bors bot merged commit 3917c29 into RIOT-OS:master Feb 18, 2023
@gschorcht
Copy link
Contributor Author

Thanks.

@gschorcht gschorcht deleted the boards/esp32s2-lilygo-ttgo-t8_fix_stdio branch March 23, 2023 14:11
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@gschorcht @riot-ci @benpicco @MrKevinWeiss